Skip to content

Conversation

@atravitz
Copy link
Contributor

currently, if you pass in an empty dir or mistype the your directory name, openfe gather will generate an empty table and even silently print it to -o.

I find this can be confusing and lead to unexpected behavior, so I'm adding a check up front, so that these scenarios are more transparent.

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested review from IAlibay and mikemhenry April 23, 2025 00:56
@atravitz atravitz marked this pull request as ready for review April 23, 2025 16:09
@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (2b79724) to head (d30ee56).
Report is 164 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   93.40%   92.69%   -0.72%     
==========================================
  Files         163      141      -22     
  Lines       12206    10799    -1407     
==========================================
- Hits        11401    10010    -1391     
+ Misses        805      789      -16     
Flag Coverage Δ
fast-tests 92.69% <100.00%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz force-pushed the add_message_for_no_results branch from 08e1b4a to 259ee7f Compare April 23, 2025 16:30
@atravitz atravitz enabled auto-merge (squash) April 23, 2025 17:17
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz added this to the v1.4.0 milestone Apr 23, 2025
@atravitz atravitz merged commit 38f0c6a into main Apr 23, 2025
13 checks passed
@atravitz atravitz deleted the add_message_for_no_results branch April 23, 2025 17:33
@atravitz atravitz mentioned this pull request Apr 23, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants