Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Apr 23, 2025

A test was breaking because I was passing in --allow-partial="". Not sure why it's only failing now, but I'm fine writing the test in this more accurate way.

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry April 23, 2025 01:29
@github-actions
Copy link

No API break detected ✅

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (e640424) to head (d02dd79).
Report is 268 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
- Coverage   94.30%   92.69%   -1.62%     
==========================================
  Files         141      141              
  Lines       10781    10783       +2     
==========================================
- Hits        10167     9995     -172     
- Misses        614      788     +174     
Flag Coverage Δ
fast-tests 92.69% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- weird it is breaking now

@mikemhenry mikemhenry merged commit d811614 into main Apr 23, 2025
12 of 13 checks passed
@mikemhenry mikemhenry deleted the fix_allow_partial_test branch April 23, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants