Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Apr 24, 2025

Imports can take 3-6 seconds, which is around the time that you think something is broken on the CLI. I'm moving our imports to right after the header prints to make it clear that the code is being executed.

Longer term, I need to see if I can speed up our imports.

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (e42432d) to head (627b5f2).
Report is 260 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   94.33%   92.73%   -1.60%     
==========================================
  Files         141      141              
  Lines       10845    10853       +8     
==========================================
- Hits        10231    10065     -166     
- Misses        614      788     +174     
Flag Coverage Δ
fast-tests 92.73% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor

yes this is good, I think things are slow b/c of the way we are using plugcli:
https://github.com/dwhswenson/plugcli/blob/main/plugcli/plugin_management.py

I am pretty sure we end up searching through every python package for plugins

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a news item, something like "Improve CLI responsiveness"

@atravitz atravitz force-pushed the speed_up_cli_stdout branch from d625805 to 627b5f2 Compare April 24, 2025 21:10
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit b6c7f19 into main Apr 24, 2025
12 of 13 checks passed
@atravitz atravitz deleted the speed_up_cli_stdout branch April 24, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants