Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Apr 25, 2025

Right now rich gets pulled in by other dependencies (openff-nagl-base and perses), but we should require it specifically.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz requested a review from mikemhenry April 25, 2025 16:11
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (9296aa7) to head (3f7c9df).
⚠️ Report is 257 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1256      +/-   ##
==========================================
- Coverage   94.34%   92.73%   -1.61%     
==========================================
  Files         141      141              
  Lines       10853    10853              
==========================================
- Hits        10239    10065     -174     
- Misses        614      788     +174     
Flag Coverage Δ
fast-tests 92.73% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay merged commit 10536f8 into main Apr 28, 2025
13 checks passed
@IAlibay IAlibay deleted the add_rich_dep branch April 28, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants