Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Apr 30, 2025

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (e4adb62) to head (0740d84).
⚠️ Report is 142 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   93.35%   92.65%   -0.71%     
==========================================
  Files         165      143      -22     
  Lines       12419    10994    -1425     
==========================================
- Hits        11594    10186    -1408     
+ Misses        825      808      -17     
Flag Coverage Δ
fast-tests 92.65% <100.00%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz requested a review from IAlibay May 19, 2025 23:06
@atravitz atravitz marked this pull request as ready for review May 19, 2025 23:06
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me as-is - just the one question

If you want to align the rbfe and rhfe help messages that would be grand, wouldn't say it's a necessity for this to get merged though.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

No API break detected ✅

@atravitz atravitz merged commit 9f386ab into main Jun 5, 2025
13 checks passed
@atravitz atravitz deleted the update_help_messages branch June 5, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants