-
Notifications
You must be signed in to change notification settings - Fork 35
Add box vector fix to AFE base #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
- Coverage 94.34% 92.73% -1.62%
==========================================
Files 141 141
Lines 10858 10858
==========================================
- Hits 10244 10069 -175
- Misses 614 789 +175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hannahbaumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IAlibay , lgtm, just the one thing to check that you put there.
|
I am testing this branch and it has so far completely resolved the problem I was facing (#1259) So far it has been 6 successful ASFE calculations with default settings. |
Amazing, thanks so much for testing this out! |
|
No API break detected ✅ |
hannahbaumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IAlibay , lgtm!
|
Forgot to add a new entry, will follow up. |
Checklist
newsentryDevelopers certificate of origin