Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented May 15, 2025

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.73%. Comparing base (0bd14c7) to head (9cbf7aa).
⚠️ Report is 274 commits behind head on main.

Files with missing lines Patch % Lines
openfe/protocols/openmm_afe/base.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
- Coverage   94.34%   92.73%   -1.62%     
==========================================
  Files         141      141              
  Lines       10858    10858              
==========================================
- Hits        10244    10069     -175     
- Misses        614      789     +175     
Flag Coverage Δ
fast-tests 92.73% <66.66%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay changed the title [WIP] Add box vector fix to AFE base Add box vector fix to AFE base May 16, 2025
@IAlibay IAlibay requested a review from hannahbaumann May 19, 2025 12:39
@hannahbaumann hannahbaumann self-assigned this May 19, 2025
Copy link
Contributor

@hannahbaumann hannahbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAlibay , lgtm, just the one thing to check that you put there.

@CurtisColwell
Copy link
Contributor

I am testing this branch and it has so far completely resolved the problem I was facing (#1259)

So far it has been 6 successful ASFE calculations with default settings.

@IAlibay
Copy link
Member Author

IAlibay commented May 21, 2025

I am testing this branch and it has so far completely resolved the problem I was facing (#1259)

So far it has been 6 successful ASFE calculations with default settings.

Amazing, thanks so much for testing this out!

@github-actions
Copy link

No API break detected ✅

Copy link
Contributor

@hannahbaumann hannahbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAlibay , lgtm!

@IAlibay IAlibay merged commit 5b1d3de into main May 22, 2025
11 of 13 checks passed
@IAlibay IAlibay deleted the afe-box-fix branch May 22, 2025 11:11
@IAlibay
Copy link
Member Author

IAlibay commented May 22, 2025

Forgot to add a new entry, will follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants