updating syntax for click 8.2 #1276
Merged
+26
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atravitz
commented
May 16, 2025
| def test_init(self, value): | ||
| ch = HyphenAwareChoice([value]) | ||
| assert ch.choices == ["foo-bar-baz"] | ||
| assert ch.choices == ("foo-bar-baz",) |
Contributor
Author
There was a problem hiding this comment.
https://click.palletsprojects.com/en/stable/api/#click.Choice click now casts this to a tuple, shouldn't be an issue for us.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 92.63% 92.73% +0.10%
==========================================
Files 143 141 -2
Lines 10952 10863 -89
==========================================
- Hits 10145 10074 -71
+ Misses 807 789 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikemhenry
approved these changes
May 27, 2025
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1272
We do need to pin to >= 8.2.0 though, so I'm fine waiting a bit to merge this in.
Checklist
newsentryDevelopers certificate of origin