Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented May 19, 2025

let's see if this resolves our CI failures

closes #1263

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry May 19, 2025 21:01
@atravitz atravitz linked an issue May 19, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.74%. Comparing base (907cdfd) to head (92f1247).
⚠️ Report is 275 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
+ Coverage   92.73%   92.74%   +0.01%     
==========================================
  Files         141      141              
  Lines       10855    10858       +3     
==========================================
+ Hits        10066    10070       +4     
+ Misses        789      788       -1     
Flag Coverage Δ
fast-tests 92.74% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz enabled auto-merge (squash) May 21, 2025 16:55
@atravitz atravitz merged commit 0bd14c7 into main May 21, 2025
13 checks passed
@atravitz atravitz deleted the retry_flaky_nbs branch May 21, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add retry logic to tests that use the internet

3 participants