Skip to content

Conversation

@mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry mikemhenry marked this pull request as ready for review May 23, 2025 15:05
@mikemhenry mikemhenry requested a review from atravitz May 23, 2025 15:05
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (d2e84ee) to head (4d65bda).
⚠️ Report is 266 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
- Coverage   92.79%   92.73%   -0.06%     
==========================================
  Files         141      141              
  Lines       10863    10863              
==========================================
- Hits        10080    10074       -6     
- Misses        783      789       +6     
Flag Coverage Δ
fast-tests 92.73% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests failed but the CI is green - should this propagate through?

@mikemhenry
Copy link
Contributor Author

testing here: https://github.com/OpenFreeEnergy/openfe/actions/runs/15279385692

@atravitz
Copy link
Contributor

this is nitpicky, but can you rename the first one to be "create conda lock file and test linux" or something similar? at first glance, i wondered why only macos was being tested.
image

@mikemhenry mikemhenry requested a review from atravitz May 27, 2025 16:00
@github-actions
Copy link

No API break detected ✅

@mikemhenry
Copy link
Contributor Author

Okay! Ready for another round or review -- testing here https://github.com/OpenFreeEnergy/openfe/actions/runs/15280192376

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!!

@mikemhenry mikemhenry merged commit 67e33fa into main May 27, 2025
15 checks passed
@mikemhenry mikemhenry deleted the tweaks-to-lock-file-gen branch May 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants