Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 3, 2025

Fixes #1310

In the ABFE protocol we actually use npt.NDArray, but the openmmtools code wants list, so we should use that instead.

Developers certificate of origin

@IAlibay IAlibay requested a review from atravitz June 3, 2025 17:13
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

No API break detected ✅

@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (a7d7c72) to head (6b94931).
⚠️ Report is 251 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   94.66%   92.65%   -2.02%     
==========================================
  Files         143      143              
  Lines       10994    10994              
==========================================
- Hits        10408    10186     -222     
- Misses        586      808     +222     
Flag Coverage Δ
fast-tests 92.65% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz merged commit 50b5134 into main Jun 3, 2025
13 checks passed
@atravitz atravitz deleted the issue-1310 branch June 3, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix mypy failure on openmm_afe base

3 participants