Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jun 5, 2025

as discussed in #1193

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry June 5, 2025 23:01
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different from the default? If it is the default, do we just want to remove it?

@atravitz
Copy link
Contributor Author

atravitz commented Jun 5, 2025

Is this different from the default? If it is the default, do we just want to remove it?

I was 50/50 on this - I know in the past we've had confusion where a newer version of micromamba was pulling in a different package for whatever reason, so I thought it would be helpful to be explicit here. Happy to remove completely if you feel otherwise.

@atravitz atravitz requested a review from mikemhenry June 6, 2025 14:10
@atravitz atravitz changed the title pin micromamba version to latest [WIP] pin micromamba version to latest Jun 23, 2025
@atravitz atravitz assigned atravitz and mikemhenry and unassigned atravitz Jun 26, 2025
@github-actions
Copy link

No API break detected ✅

@mikemhenry mikemhenry enabled auto-merge (squash) July 15, 2025 19:51
@mikemhenry mikemhenry changed the title [WIP] pin micromamba version to latest pin micromamba version to latest Jul 15, 2025
@mikemhenry
Copy link
Contributor

we print out the micromamba version
image
so that will help with debugging, this will also be nice since then we will get updates without having to remember to check for them

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (9974040) to head (d0c1b87).
⚠️ Report is 126 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   95.11%   93.20%   -1.92%     
==========================================
  Files         165      165              
  Lines       12389    12389              
==========================================
- Hits        11784    11547     -237     
- Misses        605      842     +237     
Flag Coverage Δ
fast-tests 93.20% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry mikemhenry merged commit 255ac7f into main Jul 15, 2025
13 checks passed
@mikemhenry mikemhenry deleted the unpin_micromamba_ci branch July 15, 2025 20:29
@atravitz atravitz mentioned this pull request Jul 17, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants