Skip to content

Conversation

@atravitz
Copy link
Contributor

The default is element_change=True, but the docs were not accurate.

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (72b3e7f) to head (184624f).
⚠️ Report is 231 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   94.63%   92.47%   -2.17%     
==========================================
  Files         143      143              
  Lines       10962    10962              
==========================================
- Hits        10374    10137     -237     
- Misses        588      825     +237     
Flag Coverage Δ
fast-tests 92.47% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to add the rest of the flags that matter / could affect science. Otherwise lgtm!

Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit 7be2225 into main Jun 23, 2025
11 of 12 checks passed
@atravitz atravitz deleted the update_element_change_doc branch June 23, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants