Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jun 25, 2025

removing openff-models since we vendored here, plus updating some other pins.

Also pinning us to a specific example notebooks release to resolve #1296

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry June 25, 2025 18:39
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (d33975c) to head (32ee528).
⚠️ Report is 228 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   94.63%   92.47%   -2.17%     
==========================================
  Files         143      143              
  Lines       10962    10962              
==========================================
- Hits        10374    10137     -237     
- Misses        588      825     +237     
Flag Coverage Δ
fast-tests 92.47% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have strong views on OpenMM pin

@atravitz atravitz enabled auto-merge (squash) June 25, 2025 20:30
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit 67472c7 into main Jun 26, 2025
13 checks passed
@atravitz atravitz deleted the update_pins branch June 26, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pin OpenFE_ExampleNotebooks

4 participants