Skip to content

Conversation

@mattwthompson
Copy link
Contributor

@mattwthompson mattwthompson commented Jul 7, 2025

Just seeing if/how much this differs from my local setup okay, this ended up working out well.

Basically does what the change in the config file implies, saving some human effort like I saw in #1374. I have this in most of my projects and have been happy with it.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

No API break detected ✅

@mattwthompson mattwthompson marked this pull request as ready for review July 7, 2025 21:56
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (04387d7) to head (03a8824).
⚠️ Report is 121 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
- Coverage   95.11%   92.24%   -2.88%     
==========================================
  Files         165      165              
  Lines       12389    12389              
==========================================
- Hits        11784    11428     -356     
- Misses        605      961     +356     
Flag Coverage Δ
fast-tests 92.24% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry mikemhenry self-requested a review July 10, 2025 19:21
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikemhenry mikemhenry merged commit 9974040 into OpenFreeEnergy:main Jul 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants