Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jul 17, 2025

partially _resolves #1193

Checklist

  • Added a news entry

Developers certificate of origin

echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
- name: Print Latest Version
run: echo ${{ steps.latest-version.outputs.VERSION }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the action above this (latest-version) already echoes the version found, so this is redundant.

@atravitz atravitz requested a review from mikemhenry July 17, 2025 20:58
@atravitz atravitz mentioned this pull request Jul 17, 2025
9 tasks
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (6b26f13) to head (e215d2d).
⚠️ Report is 110 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1434      +/-   ##
==========================================
- Coverage   93.23%   93.20%   -0.04%     
==========================================
  Files         165      165              
  Lines       12403    12389      -14     
==========================================
- Hits        11564    11547      -17     
- Misses        839      842       +3     
Flag Coverage Δ
fast-tests 93.20% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry mikemhenry enabled auto-merge (squash) July 18, 2025 18:00
@github-actions
Copy link

No API break detected ✅

@mikemhenry
Copy link
Contributor

just prepended resolves with _ so it doesn't close the meta issue

@atravitz atravitz disabled auto-merge July 18, 2025 18:14
@atravitz atravitz merged commit 58ab70d into main Jul 18, 2025
12 checks passed
@atravitz atravitz deleted the ci/clean_up_installer branch July 18, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants