Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 18, 2025

Fixes #1420

Changes:

  • Fixes a case where bond checking would return False on residues with only one atom.
  • Undo uneccessary universe copies.
  • Adds missing stable selection tests.

Developers certificate of origin

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (6c1ec8b) to head (2b87e32).
⚠️ Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
- Coverage   95.13%   93.26%   -1.87%     
==========================================
  Files         165      165              
  Lines       12395    12419      +24     
==========================================
- Hits        11792    11583     -209     
- Misses        603      836     +233     
Flag Coverage Δ
fast-tests 93.26% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay marked this pull request as ready for review July 18, 2025 21:55
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change, I think we should include the file hash

IAlibay and others added 3 commits July 18, 2025 23:23
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
@IAlibay IAlibay enabled auto-merge July 18, 2025 23:06
@github-actions
Copy link

No API break detected ✅

@IAlibay IAlibay merged commit b5b3c5f into main Jul 19, 2025
13 checks passed
@IAlibay IAlibay deleted the issue-1420 branch July 19, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

restraints: tests for stable_secondary_structure_selection

4 participants