Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jul 23, 2025

In draft mode until we decide if this bugfix in openmm 8.3.1 is critical.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz requested a review from IAlibay July 23, 2025 15:45
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.14%. Comparing base (c8a6a3f) to head (9059e8d).
⚠️ Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   95.19%   93.14%   -2.05%     
==========================================
  Files         165      165              
  Lines       12433    12433              
==========================================
- Hits        11835    11581     -254     
- Misses        598      852     +254     
Flag Coverage Δ
fast-tests 93.14% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay
Copy link
Member

IAlibay commented Jul 23, 2025

All good to go with 8.3. Pressure issue only affected reporting.

@atravitz atravitz marked this pull request as ready for review July 23, 2025 17:30
@atravitz atravitz merged commit b8147d5 into main Jul 23, 2025
13 checks passed
@atravitz atravitz deleted the add_openmm83 branch July 23, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants