Skip to content

Conversation

@hannahbaumann
Copy link
Contributor

@hannahbaumann hannahbaumann commented Jul 30, 2025

Checklist

  • Added a news entry

Developers certificate of origin

@hannahbaumann
Copy link
Contributor Author

@IAlibay I changed this is in the restraints settings, or should I first change and test this on the protocol level?

@hannahbaumann hannahbaumann requested a review from IAlibay July 30, 2025 14:38
@hannahbaumann
Copy link
Contributor Author

This PR is changing the default force constant in the Boresch settings to what has been used in the work by Wu et al (1 kcal/mol/Ų for the distance and 80 kcal/mol/rad² for the angle and dihedral angle restraints).

@IAlibay
Copy link
Member

IAlibay commented Jul 31, 2025

@IAlibay I changed this is in the restraints settings, or should I first change and test this on the protocol level?

At the restraint settings level sounds good to me. SepTop and ABFE should behave the same way on a "single molecule" level.

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.01%. Comparing base (023efeb) to head (9d70129).
⚠️ Report is 93 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1463   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         165      165           
  Lines       12476    12476           
=======================================
  Hits        11605    11605           
  Misses        871      871           
Flag Coverage Δ
fast-tests 93.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

No API break detected ✅

@IAlibay IAlibay merged commit 29e98fa into main Aug 1, 2025
13 checks passed
@IAlibay IAlibay deleted the update-restraint-setting-defaults branch August 1, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restraints: Reduce default host max distance in settings Restraints: Update default force constant in settings

3 participants