-
Notifications
You must be signed in to change notification settings - Fork 35
Update restraint settings (force constant and min/max distance) #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@IAlibay I changed this is in the restraints settings, or should I first change and test this on the protocol level? |
|
This PR is changing the default force constant in the Boresch settings to what has been used in the work by Wu et al (1 kcal/mol/Ų for the distance and 80 kcal/mol/rad² for the angle and dihedral angle restraints). |
At the restraint settings level sounds good to me. SepTop and ABFE should behave the same way on a "single molecule" level. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 165 165
Lines 12476 12476
=======================================
Hits 11605 11605
Misses 871 871
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No API break detected ✅ |
Checklist
newsentryDevelopers certificate of origin