Skip to content

Conversation

@mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.54%. Comparing base (023efeb) to head (c55eaaf).
⚠️ Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
- Coverage   93.01%   92.54%   -0.48%     
==========================================
  Files         165      165              
  Lines       12476    12572      +96     
==========================================
+ Hits        11605    11635      +30     
- Misses        871      937      +66     
Flag Coverage Δ
fast-tests 92.54% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor Author

@mikemhenry
Copy link
Contributor Author

image Looks like it failed to get a GPU, I need to make this fail fast if openmm can't get a GPU, I've got a script that can test this.

@mikemhenry
Copy link
Contributor Author

This failure is unrelated to the new openmmforcefields

@mikemhenry mikemhenry changed the title Test openmmforcefields 0.15.0 Test openmmforcefields 0.15.0 openmmtools 0.25.1 Aug 12, 2025
@mikemhenry mikemhenry changed the title Test openmmforcefields 0.15.0 openmmtools 0.25.1 Test openmmforcefields 0.15.0 openmmtools 0.25.1 pymbar 4.1.0 Aug 12, 2025
@github-actions
Copy link

No API break detected ✅

@mikemhenry
Copy link
Contributor Author

@IAlibay @atravitz
Do we need to do anymore QA than this PR to feel confident in bumping the openfe package pins on conda-forge to allow these versions with the current version? Updating the pins will be needed to address #1449 #1444 #1450

To be clear, we don't need to merge in this PR or make any code changes in openfe

@IAlibay
Copy link
Member

IAlibay commented Aug 13, 2025

Do we need to do anymore QA than this PR

Looking that releases notes there's nothing that is likely to have a large impact.
We might want to do a few benchmarks before our next release, but it's no a big need (we can do them alongside 8.3.1 testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants