-
Notifications
You must be signed in to change notification settings - Fork 35
Move ligand utils to gufe #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
- Coverage 95.23% 92.37% -2.87%
==========================================
Files 165 165
Lines 12640 12640
==========================================
- Hits 12038 11676 -362
- Misses 602 964 +362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks good -- it will require us to pin to the version of gufe we release with P.S. This argument only holds water if there is some reason a user wouldn't want to update to the latest gufe, AFAIK there isn't any new deps or major changes that warrant this so I believe it is a moot point |
I agree - if this were moving to any package other than gufe, I would do a deprecation cycle before moving the code. But since gufe and openfe are closely tied and we make releases together, I think this is fine. |
|
No API break detected ✅ |
partially addresses #560, along with OpenFreeEnergy/gufe#602
Checklist
newsentryDevelopers certificate of origin