Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Aug 15, 2025

partially addresses #560, along with OpenFreeEnergy/gufe#602

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz self-assigned this Aug 15, 2025
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (d0af3f5) to head (f9c1688).
⚠️ Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   95.23%   92.37%   -2.87%     
==========================================
  Files         165      165              
  Lines       12640    12640              
==========================================
- Hits        12038    11676     -362     
- Misses        602      964     +362     
Flag Coverage Δ
fast-tests 92.37% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz marked this pull request as ready for review August 15, 2025 22:31
@mikemhenry
Copy link
Contributor

This looks good -- it will require us to pin to the version of gufe we release with LigandAtomMapping.get_alchemical_charge_difference() I will approve this BUT something to maybe consider is we keep the deprecation warning in for a release before we require an update to the latest gufe.

P.S. This argument only holds water if there is some reason a user wouldn't want to update to the latest gufe, AFAIK there isn't any new deps or major changes that warrant this so I believe it is a moot point

@atravitz
Copy link
Contributor Author

This looks good -- it will require us to pin to the version of gufe we release with LigandAtomMapping.get_alchemical_charge_difference() I will approve this BUT something to maybe consider is we keep the deprecation warning in for a release before we require an update to the latest gufe.

P.S. This argument only holds water if there is some reason a user wouldn't want to update to the latest gufe, AFAIK there isn't any new deps or major changes that warrant this so I believe it is a moot point

I agree - if this were moving to any package other than gufe, I would do a deprecation cycle before moving the code. But since gufe and openfe are closely tied and we make releases together, I think this is fine.

@atravitz atravitz enabled auto-merge (squash) August 18, 2025 18:37
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit 822df43 into main Aug 26, 2025
13 checks passed
@atravitz atravitz deleted the move_ligand_utils_to_gufe branch August 26, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants