Add clear error for constraint KeyError #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
+ Coverage 92.38% 93.20% +0.82%
==========================================
Files 172 172
Lines 14482 14482
==========================================
+ Hits 13379 13498 +119
+ Misses 1103 984 -119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
requested changes
Sep 23, 2025
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
This fix looks good to me, but we'll need a test case 😅
Yes I know this code is wildly untested, so I might be being unfair. However, something something the best time to test was yesterday, the second best time is today.
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #1093 by adding an informative error.
It is possible we may want to try and handle this case gracefully in the future, however we need to collect at least the other known failure mode before we can implement a fix, so this is a stopgap.
Checklist
newsentryDevelopers certificate of origin