-
Notifications
You must be signed in to change notification settings - Fork 35
Change the default atom mapping in the CLI to Kartograf #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 95.25% 93.20% -2.05%
==========================================
Files 172 172
Lines 14482 14487 +5
==========================================
- Hits 13795 13503 -292
- Misses 687 984 +297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on my end, although I'm concerned that no tests failed when you did that 🤔 is there a long test that checks the network generation maybe?
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let @atravitz be the approver here
|
We do have a planning test for the CLI, but in this case we are lucky and got the same edges (tyk2 has good alignment and we made the edge order reproducible!), so no test failed. I have added a check for the default settings used in the CLI by matching some info in the output stream. This could be improved in future when we have provenance on the |
Yeah - board approved it too. We're selling it as "this is what was used in the industry benchmarks". |
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I agree with @jthorton about adding more tests once we store this info.
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
|
No API break detected ✅ |

Fixes #1493 by changing the default atom mapper used in the CLI to Kartograf.
Note:
Checklist
newsentryDevelopers certificate of origin