Skip to content

Conversation

@atravitz
Copy link
Contributor

NOTE: this targets the to_pydantic_v2 branch so that I can get @hannahbaumann's review on just the septop pydanticv2 updates.

@atravitz atravitz marked this pull request as draft September 24, 2025 21:00
@atravitz
Copy link
Contributor Author

@hannahbaumann I'd like your feedback here - I see you use openmm units in a few places here, and I'm wondering if we can convert these all to openff units?

Copy link
Contributor

@hannahbaumann hannahbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atravitz !
Regarding the switch of openmm to openff units, for the tests that are using openmm (sampler, forces,..) I think I would stick to openmm units, otherwise you'd need a to_openmm for many things. I think other protocols are also sticking to openmm units for these.

@hannahbaumann hannahbaumann self-assigned this Sep 25, 2025
@atravitz atravitz marked this pull request as ready for review October 9, 2025 21:29
@atravitz
Copy link
Contributor Author

atravitz commented Oct 9, 2025

CI running at: https://github.com/OpenFreeEnergy/openfe/actions/workflows/ci.yaml?query=branch%3Aseptop_pydantic_v2 (not automatic because this isn't merging into main)

merge blocked by OpenFreeEnergy/gufe#637 no longer blocked

ready for review @hannahbaumann!

Copy link
Contributor

@hannahbaumann hannahbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atravitz , lgtm!

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (to_pydantic_v2@4d56cbf). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             to_pydantic_v2    #1536   +/-   ##
=================================================
  Coverage                  ?   95.30%           
=================================================
  Files                     ?      172           
  Lines                     ?    14461           
  Branches                  ?        0           
=================================================
  Hits                      ?    13782           
  Misses                    ?      679           
  Partials                  ?        0           
Flag Coverage Δ
slow-tests 95.30% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz merged commit 2292366 into to_pydantic_v2 Oct 10, 2025
11 checks passed
@atravitz atravitz deleted the septop_pydantic_v2 branch October 10, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants