-
Notifications
You must be signed in to change notification settings - Fork 35
Septop pydantic v2 #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Septop pydantic v2 #1536
Conversation
|
@hannahbaumann I'd like your feedback here - I see you use openmm units in a few places here, and I'm wondering if we can convert these all to openff units? |
hannahbaumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atravitz !
Regarding the switch of openmm to openff units, for the tests that are using openmm (sampler, forces,..) I think I would stick to openmm units, otherwise you'd need a to_openmm for many things. I think other protocols are also sticking to openmm units for these.
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
CI running at: https://github.com/OpenFreeEnergy/openfe/actions/workflows/ci.yaml?query=branch%3Aseptop_pydantic_v2 (not automatic because this isn't merging into
ready for review @hannahbaumann! |
hannahbaumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atravitz , lgtm!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## to_pydantic_v2 #1536 +/- ##
=================================================
Coverage ? 95.30%
=================================================
Files ? 172
Lines ? 14461
Branches ? 0
=================================================
Hits ? 13782
Misses ? 679
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NOTE: this targets the
to_pydantic_v2branch so that I can get @hannahbaumann's review on just the septop pydanticv2 updates.