Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Oct 7, 2025

Thanks @jthorton for flagging that this is confusing.

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from jthorton October 7, 2025 12:44
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

No API break detected ✅

Copy link
Collaborator

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atravitz atravitz merged commit 0d4fabb into main Oct 7, 2025
6 of 12 checks passed
@atravitz atravitz deleted the add_env_comment branch October 7, 2025 12:56
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.19%. Comparing base (48a9500) to head (ebb7ead).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
- Coverage   95.25%   93.19%   -2.06%     
==========================================
  Files         172      172              
  Lines       14467    14467              
==========================================
- Hits        13780    13483     -297     
- Misses        687      984     +297     
Flag Coverage Δ
fast-tests 93.19% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants