add dark mode to docs #1565
Merged
add dark mode to docs #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atravitz
force-pushed
the
docs/add_darkmode
branch
from
5c155db to
3bcf0de
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
- Coverage 95.31% 93.26% -2.06%
==========================================
Files 172 172
Lines 14482 14482
==========================================
- Hits 13803 13506 -297
- Misses 679 976 +297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
force-pushed
the
docs/add_darkmode
branch
from
cbf8a95 to
f898bb7
Compare
atravitz
commented
Oct 13, 2025
Contributor
Author
|
@jameseastwood this is ready for review, but I'm leaving it as a draft because it shouldn't be merged until the ofe-sphinx-theme release happens. |
jameseastwood
approved these changes
Oct 15, 2025
Contributor
jameseastwood
left a comment
jameseastwood
left a comment
There was a problem hiding this comment.
fixed the specific problems Irfan had pointed out before, and also fixed problems an old version of dark mode colors had with highlighted text.
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downstream of #1574
resolves #1551
Checklist
newsentryDevelopers certificate of origin