Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 17, 2025

Tiny one I didn't see during review.

Developers certificate of origin

Removed comments about creating DAG and dry running solvent unit.
@github-actions
Copy link

No API break detected ✅

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (371441f) to head (61cc454).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
- Coverage   95.45%   93.41%   -2.05%     
==========================================
  Files         174      174              
  Lines       14542    14542              
==========================================
- Hits        13881    13584     -297     
- Misses        661      958     +297     
Flag Coverage Δ
fast-tests 93.41% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hannahbaumann hannahbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAlibay , lgtm!

@IAlibay IAlibay merged commit e595b81 into main Oct 17, 2025
13 checks passed
@IAlibay IAlibay deleted the IAlibay-patch-1 branch October 17, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants