Skip to content

Conversation

@atravitz
Copy link
Contributor

part 3 of 4 - I'll do the cli tests in a follow-up

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 87.47300% with 116 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.88%. Comparing base (25933de) to head (43c9c7a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/protocols/openmm_rfe/test_hybrid_top_protocol.py 85.11% 32 Missing ⚠️
...tests/protocols/openmm_rfe/test_hybrid_top_slow.py 9.09% 20 Missing ⚠️
.../tests/protocols/openmm_septop/test_septop_slow.py 27.77% 13 Missing ⚠️
...fe/tests/protocols/openmm_md/test_plain_md_slow.py 14.28% 12 Missing ⚠️
openfe/tests/protocols/conftest.py 79.48% 8 Missing ⚠️
...enfe/tests/protocols/openmm_ahfe/test_ahfe_slow.py 11.11% 8 Missing ⚠️
...enfe/tests/protocols/openmm_abfe/test_abfe_slow.py 22.22% 7 Missing ⚠️
...ests/protocols/openmm_md/test_plain_md_protocol.py 86.11% 5 Missing ⚠️
.../tests/protocols/openmm_ahfe/test_ahfe_settings.py 50.00% 4 Missing ⚠️
.../tests/protocols/openmm_abfe/test_abfe_energies.py 40.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   95.33%   92.88%   -2.45%     
==========================================
  Files         183      183              
  Lines       15765    15763       -2     
==========================================
- Hits        15030    14642     -388     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.88% <87.47%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

No API break detected ✅

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally just skimmed, but nothing hurt my eyes so I say it's fine.

@atravitz atravitz merged commit d7196d1 into main Oct 24, 2025
12 of 13 checks passed
@atravitz atravitz deleted the ci/add-ruff-format-part3 branch October 24, 2025 21:44
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants