-
Notifications
You must be signed in to change notification settings - Fork 35
Update conda pkg test + test to see if it catches missing files #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
==========================================
- Coverage 95.34% 92.89% -2.45%
==========================================
Files 183 183
Lines 15779 15779
==========================================
- Hits 15044 14658 -386
- Misses 735 1121 +386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This passed, but should have failed, since it failed on conda-forge: |
|
locally it also seems to be passing, going to confirm (locally) via a git checkout of version that was failing on conda forge (not just my attempt to re-create it) really fails, since maybe my attempt at re-creating the issue is failing |
|
It works! This was an error we ran into when shipping 1.7.0 |
|
okay and this one should pass https://github.com/OpenFreeEnergy/openfe/actions/runs/18918593599 |
|
@atravitz Do we want to run this on some schedule? |
|
id prefer:
|
|
Okay I think I got everything you asked for. I also added a trigger for a push to a branch called |
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small thing!
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
|
No API break detected ✅ |
Checklist
newsentryDevelopers certificate of origin