Skip to content

Conversation

@mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (d46db57) to head (3a1aef4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   95.34%   92.89%   -2.45%     
==========================================
  Files         183      183              
  Lines       15779    15779              
==========================================
- Hits        15044    14658     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.89% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor Author

This passed, but should have failed, since it failed on conda-forge:
https://github.com/OpenFreeEnergy/openfe/actions/runs/18854557811/job/53799069641

@mikemhenry
Copy link
Contributor Author

locally it also seems to be passing, going to confirm (locally) via a git checkout of version that was failing on conda forge (not just my attempt to re-create it) really fails, since maybe my attempt at re-creating the issue is failing

@mikemhenry
Copy link
Contributor Author

It works!
https://github.com/OpenFreeEnergy/openfe/actions/runs/18917837170/job/54005864677#step:8:933
ERROR: Package 'openfe' requires a different Python: 3.10.19 not in '>=3.11'

This was an error we ran into when shipping 1.7.0

@mikemhenry
Copy link
Contributor Author

@mikemhenry mikemhenry marked this pull request as ready for review October 30, 2025 15:36
@mikemhenry mikemhenry requested a review from atravitz October 30, 2025 15:36
@mikemhenry
Copy link
Contributor Author

@atravitz Do we want to run this on some schedule?

@atravitz
Copy link
Contributor

id prefer:

  • trigger on any branch that starts with release
  • it's already included in the manual tests list in this PR template
  • we can run it weekly as a safety net

@mikemhenry
Copy link
Contributor Author

Okay I think I got everything you asked for. I also added a trigger for a push to a branch called release/* so that if we made a branch called release/1.7.1 it should run on each push to that branch. I did that since right now that branch would target main as a PR and then it wouldn't actually run with just a PR target for release/*.

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing!

mikemhenry and others added 2 commits November 9, 2025 12:42
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
@mikemhenry mikemhenry requested a review from atravitz November 9, 2025 19:42
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

No API break detected ✅

@atravitz atravitz merged commit aa83a61 into main Nov 9, 2025
13 checks passed
@atravitz atravitz deleted the feat/update-conda-pkg-test branch November 9, 2025 22:20
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants