pin openmm to <8.3 #1633
Merged
pin openmm to <8.3 #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atravitz
commented
Oct 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
==========================================
- Coverage 95.33% 92.88% -2.45%
==========================================
Files 183 183
Lines 15763 15763
==========================================
- Hits 15028 14642 -386
- Misses 735 1121 +386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
well that doesn't seem right |
Contributor
Author
ah, this is the |
Contributor
Author
|
@mikemhenry I think this is good for now, but we want to follow up with a perses vendor and a perses feedstock pin to |
atravitz
force-pushed
the
maint/pin-openmm-version
branch
from
e4eb753 to
44b035f
Compare
|
No API break detected ✅ |
mikemhenry
approved these changes
Oct 28, 2025
Contributor
mikemhenry
left a comment
mikemhenry
left a comment
There was a problem hiding this comment.
LGTM but I had one question about the dask version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinning the development environment.yaml until we verify that openmm/openmm#5069 is fixed.
because this is GPU-related, I see the tests fail locally but it doesn't affect our PR CPU tests.
Checklist
newsentryDevelopers certificate of origin