Skip to content

Conversation

@mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Oct 29, 2025

There was one mistake in #1640, this PR fixes that mistake.
We need to wait to import things from perses directly until after we check we have the package available.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz self-requested a review October 29, 2025 22:10
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (0a5265f) to head (6cbb402).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   95.34%   92.89%   -2.45%     
==========================================
  Files         183      183              
  Lines       15779    15779              
==========================================
- Hits        15044    14658     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.89% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor Author

mikemhenry commented Oct 29, 2025

Locally, the tests pass!
All the tests in test_perses_scorers.py are set to XPASS so they don't really run.

@mikemhenry mikemhenry enabled auto-merge (squash) October 29, 2025 22:37
@mikemhenry mikemhenry merged commit 932f9f0 into main Oct 30, 2025
13 checks passed
@mikemhenry mikemhenry deleted the fix/pr#1640 branch October 30, 2025 00:13
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants