Skip to content

Conversation

@mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (fcf0229) to head (846245b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
- Coverage   95.34%   92.89%   -2.45%     
==========================================
  Files         183      183              
  Lines       15779    15779              
==========================================
- Hits        15044    14658     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.89% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor Author

We will need to make sure the cache clearing action doesn't end up deleting the pooch cache, but since it should be able to restore the cache from main it should be okay. I will keep an eye on it.

@github-actions
Copy link

No API break detected ✅

@mikemhenry mikemhenry requested a review from atravitz October 31, 2025 22:10
@mikemhenry
Copy link
Contributor Author

I tested this by running a test that uses pooch and cranking the log level up so I could see if things were downloaded and when there was a cache hit it didn't download the files and the tests passed so it worked!!

@atravitz atravitz merged commit 728a681 into main Nov 3, 2025
20 of 21 checks passed
@atravitz atravitz deleted the feat/create-pooch-cache branch November 3, 2025 16:12
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants