Skip to content

Conversation

@atravitz
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

# See here for more details: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths
paths-ignore:
- "docs/*"
- "news/*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems practical

@@ -1,13 +1,13 @@
name: "CI"
on:
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I updated this to be more strict ( it was "Require approval for first-time contributors" before):

Image

and then we can use: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, I figured a trust on first use model (like the one we use for ssh) was okay, but I don't think we can be too careful. It does mean we can be quicker to let someone merge in a one line typo change since it then doesn't get them into the "run without approval" list

@github-actions
Copy link

No API break detected ✅

@atravitz
Copy link
Contributor Author

@mikemhenry please take a look after this is merged.

@atravitz atravitz merged commit fcf0229 into main Oct 30, 2025
11 of 12 checks passed
@atravitz atravitz deleted the ci/update_ci_rules branch October 30, 2025 23:43
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (a7c68fd) to head (2f40a2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   95.34%   92.89%   -2.45%     
==========================================
  Files         183      183              
  Lines       15779    15779              
==========================================
- Hits        15044    14658     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.89% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants