Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 10, 2025

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry November 10, 2025 22:41
@mikemhenry
Copy link
Contributor

pre-commit.ci autofix

@github-actions
Copy link

No API break detected ✅

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We will want to include a PR that also fixes the git blame

@mikemhenry mikemhenry enabled auto-merge (squash) November 10, 2025 22:46
@atravitz
Copy link
Contributor Author

atravitz commented Nov 10, 2025

LGTM! We will want to include a PR that also fixes the git blame

yes! i have a batch of these coming through then I'll do one git blame PR for all of them

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (588f552) to head (85d6f37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   95.33%   92.89%   -2.45%     
==========================================
  Files         183      183              
  Lines       15769    15769              
==========================================
- Hits        15034    14648     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.89% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry mikemhenry merged commit 18f211d into main Nov 11, 2025
13 checks passed
@mikemhenry mikemhenry deleted the ci/add_ruff_linting_1 branch November 11, 2025 00:19
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants