Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 11, 2025

These are some actual (if minor) code changes.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.89%. Comparing base (18f211d) to head (42b6098).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
openfe/utils/logging_filter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   95.33%   92.89%   -2.45%     
==========================================
  Files         183      183              
  Lines       15769    15770       +1     
==========================================
- Hits        15034    14649     -385     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.89% <92.30%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving the not took me a bit to understand it but I like how it wants it swapped like that

@mikemhenry mikemhenry merged commit b693d37 into main Nov 11, 2025
12 of 13 checks passed
@mikemhenry mikemhenry deleted the ci/add_ruff_linting_2 branch November 11, 2025 18:34
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants