-
Notifications
You must be signed in to change notification settings - Fork 35
Disable JAX acceleration by default #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TODO: This needs a news item! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
- Coverage 95.47% 93.16% -2.32%
==========================================
Files 187 187
Lines 16244 16244
==========================================
- Hits 15509 15133 -376
- Misses 735 1111 +376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We decided to add a warning that links to a document page that describes this behavior. |
|
Actually I forgot that when you set an envar within python it only exists for the python process and doesn't stay around: this prints 2 blank lines for me, if it stayed around, it would print a blank line and a line that says |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL Python is a shell with its own local env variables. Thanks @mikemhenry !
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with adding an example error output, otherwise LGTM!
|
actually I need to add a news entry, I will edit the JAX warning one |
|
No API break detected ✅ |

Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofixbefore requesting review.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin