Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 26, 2025

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry November 26, 2025 20:24
@github-actions
Copy link

No API break detected ✅

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.01%. Comparing base (f0f968f) to head (e84f42c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
- Coverage   95.41%   93.01%   -2.41%     
==========================================
  Files         185      185              
  Lines       16045    16045              
==========================================
- Hits        15310    14924     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 93.01% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay merged commit 013b4b3 into main Nov 26, 2025
13 checks passed
@IAlibay IAlibay deleted the chore/fix_gather_warnings branch November 26, 2025 21:49
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants