docs: handle common case where ExampleNotebooks already exists and is on a tag #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on a tagged release
|
No API break detected ✅ |
Contributor
Author
|
testing on the ExampleNotebooks side here: OpenFreeEnergy/ExampleNotebooks#271 |
mikemhenry
approved these changes
Dec 4, 2025
| repo = Repo.clone_from( | ||
| repo = git.Repo.clone_from( | ||
| "https://github.com/OpenFreeEnergy/ExampleNotebooks.git", | ||
| branch="2025.10.2", |
Contributor
There was a problem hiding this comment.
idea for the future: this should point to the stable release branch so we don't have to remember to update this for each release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root cause of these failures: https://github.com/OpenFreeEnergy/ExampleNotebooks/actions/workflows/openfe-doc-build.yaml
now that we clone from a specific release, this is more common and causes docs builds to fail with that warning.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofixbefore requesting review.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin