Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 5, 2025

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@IAlibay
Copy link
Member Author

IAlibay commented Dec 5, 2025

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (3e2976c) to head (098c480).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   95.36%   93.13%   -2.23%     
==========================================
  Files         189      189              
  Lines       16536    16647     +111     
==========================================
- Hits        15770    15505     -265     
- Misses        766     1142     +376     
Flag Coverage Δ
fast-tests 93.13% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay changed the title Add AbsoluteAlchemicalSettings Add AbsoluteFactory options to AlchemicalSettings Dec 6, 2025
@IAlibay
Copy link
Member Author

IAlibay commented Dec 6, 2025

pre-commit.ci autofix

@IAlibay IAlibay requested a review from jthorton December 6, 2025 02:30
Copy link
Collaborator

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IAlibay
Copy link
Member Author

IAlibay commented Dec 8, 2025

pre-commit.ci autofix

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

No API break detected ✅

@mikemhenry
Copy link
Contributor

Docs are building okay on main/other PRs so this does something to make the doc building unhappy -- I can investigate

@atravitz atravitz merged commit c534c75 into main Dec 8, 2025
17 of 19 checks passed
@atravitz atravitz deleted the absolute_alchemicalsettings branch December 8, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants