Get ExampleNotebooks into docs #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 91.32% 91.38% +0.05%
==========================================
Files 117 117
Lines 7358 7358
==========================================
+ Hits 6720 6724 +4
+ Misses 638 634 -4 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
This one depends on OpenFreeEnergy/ExampleNotebooks#81 |
Contributor
Author
|
This is ready for review once OpenFreeEnergy/ExampleNotebooks#84 is merged! |
Member
|
Close/reopen to trigger CI build, now that OpenFreeEnergy/ExampleNotebooks#84 is merged. |
dwhswenson
approved these changes
Oct 10, 2023
Member
dwhswenson
left a comment
dwhswenson
left a comment
There was a problem hiding this comment.
Looks good! (to within that 1 Safari CSS issue) Builds fine now that the ExampleNotebooks PR is in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is all about getting notebooks from https://github.com/OpenFreeEnergy/ExampleNotebooks/ into the docs.
Developers certificate of origin