Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 4, 2024

Fixes #805 #790

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (0dd3a73) to head (2bb2d4e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   94.12%   92.31%   -1.82%     
==========================================
  Files         133      133              
  Lines        9767     9767              
==========================================
- Hits         9193     9016     -177     
- Misses        574      751     +177     
Flag Coverage Δ
fast-tests 92.31% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -29,20 +29,18 @@ calculate the free energy differences between the two
:class:`.ChemicalSystem`\ s that are the nodes for that edge. In addition to
containing the information for each :class:`.ChemicalSystem`, the
:class:`.Transformation` also contains a :class:`.Protocol` and, when
relevant, atom mapping information for alchemical transformations.

A :class:`.ChemicalSystem` is made up of one or more ``ChemicalComponent``\
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these bits because they are duplicates of other setup pages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very much just a draft image - any ideas on a better one would be greatly appreciated!

* :class:`.RBFEAlchemicalNetworkPlanner`: creating relative binding free energy networks using :class:`.RelativeHybridTopologyProtocol`
* :class:`.RHFEAlchemicalNetworkPlanner`: creating relative hydration free energy networks using :class:`.RelativeHybridTopologyProtocol`

The `Relative Alchemical Network Planners cookbook <../../cookbook/rfe_alchemical_planners>`_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR for cookbook is here: OpenFreeEnergy/ExampleNotebooks#124

@IAlibay IAlibay requested a review from RiesBen April 5, 2024 07:26
@IAlibay IAlibay changed the title [WIP] Add alchemical network creation userguide page Add alchemical network creation userguide page Apr 8, 2024
@IAlibay IAlibay closed this Apr 8, 2024
@IAlibay IAlibay reopened this Apr 8, 2024
Copy link
Contributor

@RiesBen RiesBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this bit :)

Please see the :ref:`RBFE CLI tutorial <rbfe_cli_tutorial.html>`
for an example on how to use the CLI to run an RBFE campaign.

.. todo: link to appropriate CLI page in the userguide?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this this one?

.. _guide-introduction:

@IAlibay
Copy link
Member Author

IAlibay commented Apr 9, 2024

Something's up with the cookbooks, for some reason the references aren't working. I suspect I won't have much time to hunt this one down, can someone else look into this?

@richardjgowers richardjgowers force-pushed the userguide-alchemical-networks branch from 88ca0ce to 8a362fa Compare April 10, 2024 15:52
@richardjgowers richardjgowers merged commit bb93f38 into main Apr 10, 2024
@richardjgowers richardjgowers deleted the userguide-alchemical-networks branch April 10, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User guide: Creating an alchemical network page

4 participants