including comments from #793 #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
- Coverage 94.12% 92.31% -1.82%
==========================================
Files 133 133
Lines 9767 9767
==========================================
- Hits 9193 9016 -177
- Misses 574 751 +177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
IAlibay
requested changes
Apr 8, 2024
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Thanks for doing this @RiesBen!
This looks good to me just the one text change suggestion - also we'll need to get OpenFreeEnergy/ExampleNotebooks#124 merged first to see if we can get this build working.
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
IAlibay
reviewed
Apr 11, 2024
IAlibay
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor rework of the section, including feedback from #793