CoinSorter v2 advanced

[kochebina]

ref data for test072 is here:
https://doi.org/10.6084/m9.figshare.25992610.v1

[kochebina]

@tbaudier, could you, please, update the tests ?
Otherwise the PR will never pass the checks.

Or should I do the tests update in a different PR ?

[nkrah]

What's the status on this? The tests provided by this PR do not seem to pass. Is there an issue to be solved?

[kochebina]

What's the status on this? The tests provided by this PR do not seem to pass. Is there an issue to be solved?

Hi Nils,

There are several things:

1. New tests should be used and they are also in this PR (maybe I should use a new PR to add the new tests before?)
2. The data was not enough specific --> Corrected
3. Several additional bugs are found --> I am on it
   So, the work is in progress.

Cheers,
Olga

[nkrah]

Great.
No need for a new PR. Just push commits into this one. That might be new tests, or modified tests. You can also remove obsolete tests (the removal is tracked as a commit by github).
The data is handled via a separate repository, as you know. Please contact Thomas if you need help on that.

Please post here if you want anyone to review the code or if you think the PR is ready to be considered for merging.

[nkrah]

I am a bit confused: Is this PR linked to PR #557 ?
Is this still relevant or only #557 ?

[kochebina]

@nkrah
Hi Nils, No.
As I wrote in my email last week: the release will be with the simplified coincidence sorter, thus, with corresponding documentation

[nkrah]

OK, so both PRs, #557 and this one (#410) are still WIP?
Sorry, but there is plenty of movement going on in the repo and it is better to be sure that we don't miss/mix up things.

It would be best to post PR related things here in the PR-related chat so communication remains linked together.

[kochebina]

@tbaudier @nkrah @dsarrut

This PR is ready to be merged.
The new test data is here:
https://doi.org/10.6084/m9.figshare.28063244.v1