Refactor add_macaco1_camera function #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated MACACO1 camera configuration with new components and sizes.
anetxe
requested changes
Dec 16, 2025
Collaborator
anetxe
left a comment
anetxe
left a comment
There was a problem hiding this comment.
Hi Zaina,
Can you verify these few things and make the changes accordingly? thank!
| camera.size = [4 * cm, 4 * cm, 7.6 * cm] | ||
| camera.color = [1, 1, 1, 1] # white | ||
| camera.size = [16 * cm, 40 * cm, 7.6 * cm] | ||
| camera.translation = [0, 0, 8.3 * cm] |
Collaborator
There was a problem hiding this comment.
Please, put by default the camera at the center of the world. The user should then place it in the main simulation file.
| # Scatterer | ||
| holder1 = sim.add_volume("Box", f"{name}_Holder1") | ||
| holder1.mother = camera.name | ||
| holder1.material = "G4_PLASTIC_SC_VINYLTOLUENE" |
Collaborator
There was a problem hiding this comment.
Why not. But check please if this material corresponds to the one defined previously
Plastic: d=1.18 g/cm3 ; n=3; state=solid
+el: name=Carbon ; n=5
+el: name=Hydrogen ; n=8
+el: name=Oxygen ; n=2
| pcb_scatt.mother = camera.name | ||
| pcb_scatt.material = "PCB" | ||
| pcb_scatt.size = [10.89 * cm, 20.7 * cm, 0.4 * cm] | ||
| pcb_scatt.translation = [0, 6.25 * cm, -2.26 * cm] |
Collaborator
There was a problem hiding this comment.
Check translation. Is not -2.46 cm?
| # Absorber | ||
| holder2 = sim.add_volume("Box", f"{name}_Holder2") | ||
| holder2.mother = camera.name | ||
| holder2.material = "G4_PLASTIC_SC_VINYLTOLUENE" |
Collaborator
There was a problem hiding this comment.
same here. Check density and composition please
Thanks for the review! I updated the default camera position to be at the world center, as suggested and fixed the coordinate of pcb_scatt. For the material, I checked the G4 files and it's not the same at all, I'm not sure why I used it in my code before, so I fixed it here and on vs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MACACO1 camera configuration with new components and sizes.