Conversation
johnkit
approved these changes
Jul 31, 2023
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new celery task called
network_gcc, which accepts two parametersedge_listandexclude_nodes. For now, this task is empty except for a print statement. This will be a placeholder for where we will invoke the code from NU.This PR also adds an endpoint for spawning the new task, and it does a bit of mild refactoring. To avoid overloading the
tasks.pyfile, this PR splits the celery tasks into two files:tasks/conversion.pyandtasks/networks.py.