Fix: laminar trace timeline to account for idle wait time#415
Open
Rainhunter13 wants to merge 4 commits intoOpenHands:mainfrom
Open
Fix: laminar trace timeline to account for idle wait time#415Rainhunter13 wants to merge 4 commits intoOpenHands:mainfrom
Rainhunter13 wants to merge 4 commits intoOpenHands:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix evaluation datapoint trace timeline when number of tasks exceed concurrent workers.
Previously, the root "Evaluation" span was created in the parent process alongside the datapoint, before a worker picked up the task. When more tasks were queued than available workers, the span included idle wait time, resulting in inflated durations and misleading timelines in Laminar:
Now, the "Evaluation" span is created in the child process when execution actually begins. The span's trace ID is then linked back to the Laminar datapoint via
update_datapoint, so the timeline accurately reflects real execution time.Requires
lmnr>=0.7.41forupdate_datapointtrace ID support.*The diff of
evaluation.pylooks a bit off due a newtry exceptblock + linter auto changes, might be better to look with "Hide whitespaces" option