Add Windows terminal backend support by SmartManoj · Pull Request #1012 · OpenHands/software-agent-sdk

SmartManoj · 2025-11-04T08:44:10Z

Introduces WindowsTerminal for PowerShell-based command execution on Windows systems. Updates factory and init logic to conditionally import and use platform-specific terminal backends, ensuring compatibility across Windows and Unix-like platforms.

Introduces WindowsTerminal for PowerShell-based command execution on Windows systems. Updates factory and init logic to conditionally import and use platform-specific terminal backends, ensuring compatibility across Windows and Unix-like platforms.

xingyaoww

I wonder if we should rename the tool execute_bash into execute_terminal because of the powershell here? 🤔

And we tell the agent if it is using powershell vs bash. But we can do this in subsequent pr

Simplifies the code by unconditionally importing fcntl and pty, removing the platform-specific logic and dummy assignments for Windows. This module is intended for Unix-like systems only.

SmartManoj · 2025-11-05T08:27:47Z

Deleted scripts/demo.py as it is no longer needed. The demo script previously demonstrated basic usage of the OpenHands SDK and agent setup.

Eliminated an erroneous 'n' character from the import block in terminal_session.py to clean up the code and prevent potential syntax errors.

Changed assertions in test_windows_terminal_close_and_reopen to check 'obs.text' instead of 'obs.output' for command results. This aligns the test with the updated observation object structure.

xingyaoww · 2025-11-06T19:02:16Z

@SmartManoj can you resolve merge conflicts/

Update the terminal module's __init__.py to conditionally import WindowsTerminal on Windows and SubprocessTerminal/TmuxTerminal on other platforms. This change ensures only relevant terminal classes are exposed based on the operating system.

Removed the deprecated execute_bash.terminal package and updated all relevant imports to use the new openhands.tools.terminal.terminal structure. This change consolidates terminal-related code under a single module for improved maintainability and clarity.

blacksmith-sh · 2025-11-10T12:59:39Z

[Automatic Post]: This PR seems to be currently waiting for review. @ryanhoangt, could you please take a look when you have a chance?

ryanhoangt

Thank you for the PR. When testing the PR on the examples/01_hello_world.py and adjusting the message to something like "Please check the current directory, list all files and then exit.", I saw it first attempted to run a bash command with &&, which failed in PowerShell. However, it didn't fail instantly, it got stuck in soft timeout observation loop and the agent decided to reset the terminal. Do you have any ideas why it happened?

openhands-tools/openhands/tools/terminal/terminal/__init__.py

openhands-tools/openhands/tools/terminal/terminal/factory.py

SmartManoj · 2025-11-17T12:55:34Z

I saw it first attempted to run a bash command

Does this tool description need to be updated?

software-agent-sdk/openhands-tools/openhands/tools/terminal/definition.py

Line 191 in ec8c806

    
           TOOL_DESCRIPTION = """Execute a bash command in the terminal within a persistent shell session.

xingyaoww · 2025-11-17T15:10:44Z

@SmartManoj

Does this tool description need to be updated?

Yes we should either phrase it so the description is general enough, OR we should implement a switch (i.e., only change the description if windows is selected as the terminal implementation)

Introduces TOOL_DESCRIPTION_FOR_WINDOWS for PowerShell commands and updates TerminalTool to select the appropriate description based on the platform. This improves clarity and guidance for users on both Unix and Windows systems.

SmartManoj · 2025-11-18T08:33:03Z

neubig · 2026-01-08T12:47:52Z

I'll take reviewing on this one since I'll have a windows machine soon.

all-hands-bot · 2026-01-14T12:18:11Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

neubig · 2026-01-15T19:35:06Z

I should get my windows laptop around today, will check once I do.

all-hands-bot · 2026-01-21T12:19:07Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

neubig · 2026-01-21T13:22:48Z

My laptop was delivered yesterday, will need to set it up and then will test.

all-hands-bot · 2026-01-27T12:18:46Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

all-hands-bot · 2026-02-01T12:22:36Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

neubig

Overall this looks pretty good and well structured, thanks for this! I had a few comments, and one very big one is that the browser implementation for windows seems to be missing. I'll test it once I can get that.

openhands-agent-server/openhands/agent_server/env_parser.py

openhands-tools/openhands/tools/browser_use/impl.py

openhands-tools/openhands/tools/file_editor/editor.py

tests/agent_server/test_models.py

SmartManoj · 2026-02-02T05:51:15Z

and one very big one is that the browser implementation for windows seems to be missing

It was added in a separate PR #1014

all-hands-bot · 2026-02-10T12:35:32Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

all-hands-bot · 2026-02-10T12:35:38Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

neubig · 2026-02-10T16:06:22Z

Sorry, this is on me now, re-requesting review.

all-hands-bot · 2026-02-16T12:26:04Z

[Automatic Post]: It has been a while since there was any activity on this PR. @SmartManoj, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up.

neubig · 2026-02-16T22:42:20Z

@OpenHands fix merge conflicts

openhands-ai · 2026-02-16T22:42:37Z

I'm on it! neubig can track my progress at all-hands.dev

Resolve merge conflicts in: - openhands-agent-server/openhands/agent_server/agent-server.spec - openhands-tools/openhands/tools/browser_use/impl.py Kept both Windows terminal support changes and new main features (delegate templates, browser JS recording files, recording_aware decorator). Co-authored-by: openhands <openhands@all-hands.dev>

openhands-ai · 2026-02-16T22:46:14Z

Summary

I successfully resolved the merge conflicts in PR #1012 "Add Windows terminal backend support".

Conflicts Resolved

1. openhands-agent-server/openhands/agent_server/agent-server.spec

Combined Windows terminal templates from the PR with new additions from main (delegate templates and browser JS recording files)

2. openhands-tools/openhands/tools/browser_use/impl.py

Kept the sys import and get_browser_executor_class() factory function from the PR
Added the new imports (Callable, Coroutine) and recording_aware decorator from main

Verification

✅ Pre-commit hooks pass (ruff format, ruff lint, pycodestyle, pyright, import dependency rules, tool registration check)
✅ Changes pushed to SmartManoj's fork
✅ PR is now MERGEABLE (no more conflicts)

Commit

Merge origin/main into terminal

Resolve merge conflicts in:
- openhands-agent-server/openhands/agent_server/agent-server.spec
- openhands-tools/openhands/tools/browser_use/impl.py

Kept both Windows terminal support changes and new main features
(delegate templates, browser JS recording files, recording_aware decorator).

The PR's BLOCKED status is due to CI checks that need to run, not merge conflicts.

The type annotation was using BrowserToolExecutor (a runtime variable from get_browser_executor_class()) instead of BrowserToolExecutorType (the type alias from TYPE_CHECKING block). Co-authored-by: openhands <openhands@all-hands.dev>

Add Windows terminal backend support

6789d81

Introduces WindowsTerminal for PowerShell-based command execution on Windows systems. Updates factory and init logic to conditionally import and use platform-specific terminal backends, ensuring compatibility across Windows and Unix-like platforms.

xingyaoww requested a review from ryanhoangt November 4, 2025 15:42

xingyaoww reviewed Nov 4, 2025

View reviewed changes

SmartManoj added 4 commits November 5, 2025 12:19

ruff

a1f6319

Remove platform check and always import fcntl and pty for pyright

4e064b0

Simplifies the code by unconditionally importing fcntl and pty, removing the platform-specific logic and dummy assignments for Windows. This module is intended for Unix-like systems only.

pyright

baa383e

Merge branch 'main' into terminal

4efe972

SmartManoj mentioned this pull request Nov 5, 2025

Rename execute_bash to terminal & rename BashTool to TerminalTool #1033

Merged

ruff

7939e98

SmartManoj added 4 commits November 6, 2025 08:05

Remove demo script

a7b35dd

Deleted scripts/demo.py as it is no longer needed. The demo script previously demonstrated basic usage of the OpenHands SDK and agent setup.

Merge branch 'main' into terminal

0eb8eea

Remove stray character from import statement

4fefd40

Eliminated an erroneous 'n' character from the import block in terminal_session.py to clean up the code and prevent potential syntax errors.

Update assertions to use obs.text in Windows Terminal tests

d252b38

Changed assertions in test_windows_terminal_close_and_reopen to check 'obs.text' instead of 'obs.output' for command results. This aligns the test with the updated observation object structure.

SmartManoj added 3 commits November 7, 2025 03:19

Merge branch 'main' into terminal

a2123bb

Merge branch 'main' into terminal

d0ca912

SmartManoj requested a review from xingyaoww November 15, 2025 11:12

ryanhoangt reviewed Nov 17, 2025

View reviewed changes

openhands-tools/openhands/tools/terminal/terminal/__init__.py Show resolved Hide resolved

openhands-tools/openhands/tools/terminal/terminal/factory.py Show resolved Hide resolved

Add Windows-specific terminal tool description

78791dd

Introduces TOOL_DESCRIPTION_FOR_WINDOWS for PowerShell commands and updates TerminalTool to select the appropriate description based on the platform. This improves clarity and guidance for users on both Unix and Windows systems.

SmartManoj force-pushed the terminal branch from f6f91b7 to 78791dd Compare November 18, 2025 01:51

SmartManoj added 2 commits November 18, 2025 11:21

format

bd5e3b9

Merge branch 'main' into terminal

d0002c4

ryanhoangt self-requested a review November 18, 2025 14:36

neubig self-requested a review January 8, 2026 12:47

Merge branch 'main' into terminal

1e2874f

Merge branch 'main' into terminal

8e74d72

Merge branch 'main' into terminal

0e0394c

Merge branch 'main' into terminal

8d064e8

Merge branch 'main' into terminal

59ff7ae

neubig reviewed Feb 1, 2026

View reviewed changes

neubig and others added 2 commits February 1, 2026 11:19

Merge branch 'main' into terminal

7279977

Merge branch 'main' into terminal

babdeef

SmartManoj added 2 commits February 2, 2026 11:46

revert test_update_secrets_request_invalid_dict changes

6a2c740

revert DiscriminatedUnionMixin fix

526c925

neubig self-requested a review February 10, 2026 16:06

WolffM mentioned this pull request Feb 16, 2026

fix(tools): guard Unix-only imports in terminal package for Windows #2096

Open

Conversation

SmartManoj commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xingyaoww left a comment

Choose a reason for hiding this comment

Uh oh!

SmartManoj commented Nov 5, 2025

Uh oh!

xingyaoww commented Nov 6, 2025

Uh oh!

blacksmith-sh bot commented Nov 10, 2025

Uh oh!

ryanhoangt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SmartManoj commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xingyaoww commented Nov 17, 2025

Uh oh!

SmartManoj commented Nov 18, 2025

Uh oh!

neubig commented Jan 8, 2026

Uh oh!

all-hands-bot commented Jan 14, 2026

Uh oh!

neubig commented Jan 15, 2026

Uh oh!

all-hands-bot commented Jan 21, 2026

Uh oh!

neubig commented Jan 21, 2026

Uh oh!

all-hands-bot commented Jan 27, 2026

Uh oh!

all-hands-bot commented Feb 1, 2026

Uh oh!

neubig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SmartManoj commented Feb 2, 2026

Uh oh!

all-hands-bot commented Feb 10, 2026

Uh oh!

all-hands-bot commented Feb 10, 2026

Uh oh!

neubig commented Feb 10, 2026

Uh oh!

all-hands-bot commented Feb 16, 2026

Uh oh!

neubig commented Feb 16, 2026

Uh oh!

openhands-ai bot commented Feb 16, 2026

Uh oh!

openhands-ai bot commented Feb 16, 2026

Summary

Conflicts Resolved

Verification

Commit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

SmartManoj commented Nov 4, 2025 •

edited

Loading

SmartManoj commented Nov 17, 2025 •

edited

Loading