Open
Conversation
Handle unresolved Griffe aliases and baseline missing __all__ in older releases. Add PR comment step with summarized log output. Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
Align workflow permissions with other comment-posting workflows (pull-requests: write) to avoid 403 Resource not accessible by integration. Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
API breakage checks (Griffe)Result: Passed |
all-hands-bot
approved these changes
Feb 17, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
Solid fix for the API breakage check robustness. The error handling is pragmatic - catches specific failures without aborting the entire check. Tests cover the new behavior. 👍
Core improvements:
- Handles Griffe alias resolution failures gracefully without aborting the full check
- Properly skips export-based checks when old release lacks
__all__ - PR automation with pass/fail status and log excerpts improves visibility
Minor suggestions (optional):
- Line 167 in
check_sdk_api_breakage.py:breakages: list[object]will hold both GriffeBreakageobjects and dicts. Considerlist[Any]for clarity. - Line 65 in
api-breakage.yml: Fixed 1000-char truncation might cut mid-line. Line-based truncation would be cleaner, but this works fine for a quick preview.
The refactoring in _compute_breakages that separates module resolution from export extraction is much cleaner than the original. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the API breakage check to avoid spurious warnings and improve PR visibility:
__all__, continue emitting a warning and skip export-based checks (this should be fixed in the next release).Closes #2097.
Checklist
@enyst can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:f338726-pythonRun
All tags pushed for this build
About Multi-Architecture Support
f338726-python) is a multi-arch manifest supporting both amd64 and arm64f338726-python-amd64) are also available if needed