chore: Add INFO-level logging for hook_config debugging#2099
Draft
chore: Add INFO-level logging for hook_config debugging#2099
Conversation
Add logging at key points to trace hook_config flow: - conversation_service.py: Log when StoredConversation is created - event_service.py: Log when LocalConversation receives hook_config - local_conversation.py: Log hook processor initialization and stop hook execution This helps debug issues where hooks are not being executed despite being loaded from workspace. Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Coverage Report •
|
|||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add INFO-level logging at key points to trace hook_config flow through the system.
Background
When debugging hook deployment issues in OpenHands PR #12773, we found that:
Changes
Add logging to trace hook_config at three key points:
1.
conversation_service.py2.
event_service.py3.
local_conversation.py_pending_hook_configduring plugin loadingfinal_hook_configafter merging with plugin hooksExpected Log Output
With these changes, we should see logs like:
Testing
This is a debugging change - the new logging will help identify where hook_config is being lost or why hooks aren't executing.
Related to: OpenHands/OpenHands#12773
@xingyaoww can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:407b24d-pythonRun
All tags pushed for this build
About Multi-Architecture Support
407b24d-python) is a multi-arch manifest supporting both amd64 and arm64407b24d-python-amd64) are also available if needed