Can now specify secrets on conversation start, and simplified type hints#625
Merged
Can now specify secrets on conversation start, and simplified type hints#625
Conversation
tofarr
changed the title
- Added test_start_conversation_with_secrets to verify secrets are passed to new conversations - Added test_start_conversation_without_secrets to verify default behavior - Updated conversation_service fixture to use temporary directories for test isolation - Tests verify that StaticSecret objects are properly passed through the conversation creation flow Co-authored-by: openhands <openhands@all-hands.dev>
neubig
pushed a commit
that referenced
this pull request
Feb 11, 2026
When libtmux's new_session() returns a Session with session_id=None (due to a bug in parse_output() not handling fewer output values), we now retry fetching the session from server.sessions. This is a workaround for the issue where neubig's fix PR #625 doesn't fully handle cases where tmux returns fewer than the expected 125 format field values, causing the zip() to truncate before reaching session_id at index 92. The workaround: 1. Check if session_id is None after new_session() 2. If so, retry up to 3 times with increasing delays 3. Fetch the session by name from server.sessions 4. Raise a clear error if all retries fail See: tmux-python/libtmux#624 Co-authored-by: openhands <openhands@all-hands.dev>
neubig
pushed a commit
that referenced
this pull request
Feb 11, 2026
Improved the workaround for the libtmux race condition where new_session() returns a Session with session_id=None. Changes: - Wrap entire session creation in retry loop (up to 5 attempts) - Try to get session from server.sessions if session_id is None - Add increasing delays between retries - Clean up orphan sessions before retry - Better error messages with last error included The root issue is that neubig's PR #625 fix tries to parse 125+ format fields from tmux output, but tmux may not output all fields in some environments (especially Python 3.13 + PyInstaller + Docker), causing session_id (at index 92) to be missing from the parsed output. Co-authored-by: openhands <openhands@all-hands.dev>
neubig
pushed a commit
that referenced
this pull request
Feb 11, 2026
The libtmux fix (neubig's PR #625) uses a format string with 125+ fields, but tmux may not output all fields correctly in some environments (Python 3.13 + PyInstaller + Docker), causing session_id (at index 92) to be missing from the parsed output. This adds a fallback that directly queries tmux using a simple format string ('#{session_id}:#{session_name}') to get the session_id when libtmux's complex format parsing fails. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
LocalConversationandRemoteConversationnow accept asecretsparameter during initializationsecretsfield toStartConversationRequestfor remote conversation supportdict[str, SecretValue]toMapping[str, SecretValue]for better type safety and flexibilityImpact
Enables users to provide secrets at conversation start time instead of requiring a separate
update_secrets()call, improving the developer experience for both local and remote conversations.Agent Server images for this PR
• GHCR package: https://github.com/All-Hands-AI/agent-sdk/pkgs/container/agent-server
Variants & Base Images
golang:1.21-bookwormeclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22Pull (multi-arch manifest)
Run
All tags pushed for this build
The
26a0fd6tag is a multi-arch manifest (amd64/arm64); your client pulls the right arch automatically.