Skip to content

Conversation

@PeterHamilton
Copy link
Contributor

This change adds SetAttribute support to the ProxyKmipClient, leveraging the new generic request capability in the underlying KMIPProxy client. New unit tests have been added to cover the new client additions.

Partially implements #547

This change adds SetAttribute support to the ProxyKmipClient,
leveraging the new generic request capability in the underlying
KMIPProxy client. New unit tests have been added to cover the new
client additions.

Partially implements #547
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3be2191). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #607   +/-   ##
=========================================
  Coverage          ?   96.54%           
=========================================
  Files             ?       79           
  Lines             ?    16722           
  Branches          ?        0           
=========================================
  Hits              ?    16145           
  Misses            ?      577           
  Partials          ?        0
Impacted Files Coverage Δ
kmip/services/kmip_client.py 71.03% <100%> (ø)
kmip/pie/client.py 99.37% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be2191...6d80748. Read the comment docs.

@PeterHamilton PeterHamilton merged commit 2d283e1 into master Nov 22, 2019
@PeterHamilton PeterHamilton deleted the feat/add-set-attribute-to-client branch November 22, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants